feat: 🐛 Do not crash if get_enclosing_chapter returns nil #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
someth2say
force-pushed
the
cell_enclosing_chapter
branch
from
b5476bd
to
659fb7d
Compare
|
Could we modify You can find an example of accessing the parent document from a table cell here: |
|
Please lock gepub to 1.0.15 instead as 1.0.16 is clearly broken. |
someth2say
force-pushed
the
cell_enclosing_chapter
branch
from
8603b16
to
4a5ecbc
Compare
|
In order for this to be merged, the code needs to find the chapter when starting from an AsciiDoc table cell, not just skip it. Otherwise, the metadata won't be right. |
slonopotamus
added a commit
to slonopotamus/asciidoctor-epub3
that referenced
this pull request
May 12, 2024
|
I don't see how to fix this without asciidoctor/asciidoctor#4380. See #473 for an ugly workaround. |
slonopotamus
added a commit
to slonopotamus/asciidoctor-epub3
that referenced
this pull request
May 12, 2024
slonopotamus
added a commit
to slonopotamus/asciidoctor-epub3
that referenced
this pull request
May 12, 2024
|
WRT gepub issue, see #474 and skoji/gepub#140 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #470
Probably not the best approach, but enough to protect from the crash.