Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inline video is not supported #40

Open
cmoulliard opened this issue Jan 13, 2014 · 3 comments
Open

inline video is not supported #40

cmoulliard opened this issue Jan 13, 2014 · 3 comments

Comments

@cmoulliard
Copy link
Member

When video option is added in a paragraph or a table

[width="100%"]
|============================================== 
|video:video/bob_waterslide.mp4[] |
|==============================================

HTML is not rendered with a videoblock as until now the existing templates does not support inline video like inline image, ...

<table class="tableblock frame-all grid-all" style="width:100%; ">
<colgroup>
<col style="width:50%;">
<col style="width:50%;"> 
</colgroup>
<tbody>
<tr>
<td class="tableblock halign-left valign-top"><p class="tableblock">video:video/bob_waterslide.mp4[]</p></td>
<td class="tableblock halign-left valign-top"></td>
</tr>
</tbody>
</table>
@cmoulliard
Copy link
Member Author

Question: To add a missing inlineTemplate, the way to go to resolve the issue is to:

  • do modification in asciidoctor core project (add a VideoInlineTemplate ... ) and next
  • add to haml/slim/erb HTML5 the HTML code
    ?

@LightGuard
Copy link
Member

Sounds like a great time to add a test :)

@mojavelinux
Copy link
Member

I think it's appropriate to add the AsciiDoc style (i.e., a) to the table cell and use the video block macro. A video isn't really an inline element.

shallada pushed a commit to datastax-training/asciidoctor-backends that referenced this issue Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants