Skip to content
This repository has been archived by the owner on Jan 4, 2023. It is now read-only.

Transition _cents fields to display_.._dollars fields (for non USD auctions) #502

Open
mzikherman opened this issue Aug 31, 2015 · 1 comment

Comments

@mzikherman
Copy link

In order to enable non USD auctions, recent PR's in gravity (https://github.com/artsy/gravity/pull/9179 as an example), has added JSON fields to help currency formatting.

So, any field relating to bidding that was of the form _cents (such as estimate_cents), now will also include a display_estimate_dollars field. This field (a string), will include any currency information, as well as proper formatting/rounding.

This makes it easier to actually put on a non USD auction, as clients can become 'dumber' and just render these fields directly, rather than doing a divide by 100 and add a $ sign, type thing.

This is fully backwards-compatible (it's just extra JSON) so no rush, but it would be nice (and I think net code deletion for you guys) to switch to this.

Here's an example of how Force was updated to use it: artsy/force#3334

Will open this issue in Eidolon as well.

Thanks guys! Let me know if you have questions.

@ashfurrow
Copy link
Contributor

Hey Matt! I know it's been a while since this was opened, just want to check in and see if this was still the plan?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants