Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyze aibolit report #303

Open
olenagerasimova opened this issue Jun 29, 2020 · 2 comments
Open

Analyze aibolit report #303

olenagerasimova opened this issue Jun 29, 2020 · 2 comments

Comments

@olenagerasimova
Copy link
Member

Let's analyze report (check this action) generated by aibolit and try to follow its recommendations to make our code better.
I'm proposing the following process:

  1. choose class from the report to work on,
  2. fix relevant problems and submit PR,
  3. report bugs (if any) to Aibolit,
  4. as for now there is no possibility to suppress bugs found by Aibolit, add comment here with small summary about the class you worked on: class name, problems left and why

Feel free to report any suggestion to Aibolit team and discuss any code related problems with me.

Do not close this issue when first PR is closed, I will close it when whole report by Aibolit is analyzed, or we will not need it anymore.

@olenagerasimova
Copy link
Member Author

olenagerasimova commented Jun 29, 2020

@acheshkov hi, thanks for integrating Aibolit into rpm-adapter! I'd like to start analyzing Aibolit report for rpm-adapter and reporting found problems (if any) to Aibolit. Don't you mind?
@g4s8 what do you think of proposed process?

@g4s8
Copy link
Member

g4s8 commented Jun 29, 2020

@olenagerasimova yes, I think you can report all problems here: https://github.com/yegor256/aibolit/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants