Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XmlWriterWrap should be abstract and have final methods #128

Open
victornoel opened this issue Apr 18, 2020 · 2 comments
Open

XmlWriterWrap should be abstract and have final methods #128

victornoel opened this issue Apr 18, 2020 · 2 comments

Comments

@victornoel
Copy link
Contributor

I see XmlWriterWrap was introduced in #109.

I believe that envelopes should be abstract and have all their methods be final : that would allow for removing the DesignForExtensionCheck suppression from checkstyle. It exists for good reasons, it is dangerous to use inheritance, but it is way safer when one can't override inherited behaviour.

Also it should be abstract because as a good rule, classes should be either final or abstract to avoid confusing situation with inheritance.

@0crat
Copy link

0crat commented Apr 18, 2020

@g4s8/z please, pay attention to this issue

@victornoel
Copy link
Contributor Author

@g4s8 also I'm in favour of naming it XMLStreamWriterEnvelope to reflect both the interface it envelopes and the fact it is an envelope.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants