Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle non-Symbol args in TryConvertMut for time Offset #2092

Open
lopopolo opened this issue Aug 21, 2022 · 1 comment
Open

Handle non-Symbol args in TryConvertMut for time Offset #2092

lopopolo opened this issue Aug 21, 2022 · 1 comment
Labels
A-ruby-core Area: Ruby Core types. B-mruby Backend: Implementation of artichoke-core using mruby.

Comments

@lopopolo
Copy link
Member

it looks like we need to handle non-Symbol args in the same way:

[3.1.2] > Time.at(12, 'in' => 'Z')
<internal:timev>:270:in `at': unknown keyword: "in" (ArgumentError)
        from (irb):1:in `<main>'
        from /usr/local/var/rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/irb-1.4.1/exe/irb:11:in `<top (required)>'
        from /usr/local/var/rbenv/versions/3.1.2/bin/irb:25:in `load'
        from /usr/local/var/rbenv/versions/3.1.2/bin/irb:25:in `<main>'
[3.1.2] > Time.at(12, Object.new => 'Z')
<internal:timev>:270:in `at': unknown keyword: #<Object:0x00000001091c7d70> (ArgumentError)
        from (irb):2:in `<main>'
        from /usr/local/var/rbenv/versions/3.1.2/lib/ruby/gems/3.1.0/gems/irb-1.4.1/exe/irb:11:in `<top (required)>'
        from /usr/local/var/rbenv/versions/3.1.2/bin/irb:25:in `load'
        from /usr/local/var/rbenv/versions/3.1.2/bin/irb:25:in `<main>'

Originally posted by @lopopolo in #1956 (comment)

@lopopolo lopopolo added A-ruby-core Area: Ruby Core types. B-mruby Backend: Implementation of artichoke-core using mruby. labels Aug 21, 2022
@lopopolo
Copy link
Member Author

This ticket is related to #2091.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ruby-core Area: Ruby Core types. B-mruby Backend: Implementation of artichoke-core using mruby.
Development

No branches or pull requests

1 participant