Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenGraph::addProperty on array omits "og" in property name #246

Open
schrink opened this issue Mar 29, 2021 · 3 comments
Open

OpenGraph::addProperty on array omits "og" in property name #246

schrink opened this issue Mar 29, 2021 · 3 comments

Comments

@schrink
Copy link

schrink commented Mar 29, 2021

What steps will reproduce the problem?

OpenGraph::addProperty('locale:alternate', ['en_GB', 'el_EL']);

What is the expected result?

<meta property="og:locale:alternate" content="en_GB" />
<meta property="og:locale:alternate" content="el_EL" />

What do you get instead?

<meta property=":locale:alternate" content="en_GB" />
<meta property=":locale:alternate" content="el_EL" />

Additional info

Q A
This Package Version 0.20.0
Laravel Framework Version 8.34.0
PHP version 8.03
Operating system MacOs
@J-Brk
Copy link
Collaborator

J-Brk commented Nov 29, 2021

Issue confirmed. The problem occurs when using an array. As temporary workaround I suggest to try to call addProperty with single values only until a fix has been submitted / released.

@J-Brk
Copy link
Collaborator

J-Brk commented Jul 20, 2022

It seems the bug has been introduced by the fix for issue: #74.

@sergiq
Copy link

sergiq commented Aug 24, 2023

does somebody know if there is a due date for this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants