Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove "illuminate/config" dependency #171

Open
klimov-paul opened this issue Aug 13, 2019 · 0 comments
Open

Remove "illuminate/config" dependency #171

klimov-paul opened this issue Aug 13, 2019 · 0 comments

Comments

@klimov-paul
Copy link
Contributor

At the present state this package uses Illuminate\Config\Repository for the Artesaos\SEOTools\SEOMeta implementation.
This produces an extra dependency to the "illuminate/config" package.

SEOMeta is the only class using Illuminate\Config\Repository - all other SEO tools operate plain arrays.

It is better to refactor Artesaos\SEOTools\SEOMeta removing usage of Illuminate\Config\Repository. It will make this class more consistent, easy for standalone usage and eliminates extra composer dependency.

Q A
This Package Version 0.15.0
Laravel Framework Version 5.8.31
PHP version 7.2
Operating system *
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant