Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use httpcache library for GH response caching #115

Open
MatousJobanek opened this issue Apr 16, 2018 · 1 comment
Open

Use httpcache library for GH response caching #115

MatousJobanek opened this issue Apr 16, 2018 · 1 comment
Labels
type/enhancement New feature or request

Comments

@MatousJobanek
Copy link
Contributor

The go-github library doesn't handle GH conditional requests directly but provides a possibility to work with a caching on the level of http.Transport. https://github.com/google/go-github/#conditional-requests
They recommend using https://github.com/gregjones/httpcache library for that. Since it should work as RFC 7234 compliant cache for http responses then it should minimize the GH request rate limit usage - it's using the same headers as GH conditional requests

@MatousJobanek MatousJobanek added the type/enhancement New feature or request label Apr 16, 2018
@bartoszmajsak bartoszmajsak added this to the Sprint 149 milestone Apr 18, 2018
@MatousJobanek MatousJobanek modified the milestones: Sprint 149, Sprint 150 May 30, 2018
@MatousJobanek
Copy link
Contributor Author

I'm moving this issue to icebox as (according to the metrics) it seems that we don't use many of the requests. In other words, it doesn't seem to be very important to spend time with this issue and to add an additional logic to the project when there is no danger that we could run out of the limited number of requests.

@MatousJobanek MatousJobanek removed this from the Sprint 150 milestone Jun 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants