fix(#1178): Calculate and specify a wait-for-it timeout #1179
Conversation
phillipross
force-pushed
the
1178-PollingAwaitStrategyWaitForItTimeout
branch
from
b0c2364
to
f36c8cf
Compare
|
Thanks for your contribution @phillipross. I guess I have to first fix the build (general problem, not PR related) and then we can move forward. |
|
Yes, I had to disable OpenShift tests to get my builds to work. I don't have the expertise with OpenShift to determine the problem, but figured I should submit the PR anyway. Thanks! |
|
@bartoszmajsak any progress on this? let me know if there's anything I can do to help move things alone. Thanks! |
Sorry @phillipross I didn't have time yet to look at build failures. If you have time and you are willing to dig into it that would be just awesome. I might be able to get into that later this week, but been pretty busy with other stuff lately :( |
|
I understand, no problem 😉 I believe when I looked before it seemed to be issues with the openshift integration or something, but I'll take a closer look and see what I can uncover. |
Short description of what this resolves:
When a container is configured with polling await strategy, the parameters for the strategy are used to compute a timeout and passed to the wait-for-it command.
Fixes #1178