Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard accessibility #415

Open
nicolechung opened this issue Sep 5, 2017 · 3 comments · May be fixed by #757
Open

Keyboard accessibility #415

nicolechung opened this issue Sep 5, 2017 · 3 comments · May be fixed by #757
Labels
enhancement help wanted

Comments

@nicolechung
Copy link

Is it possible to have the date picker be more keyboard-accessible?

  1. It looks like the renderDay method would need to have a <button /> with a tabIndex property inside of each <td> cell.
  2. aria-labels would need to be added
  3. (Looks more work-intensive) keyboard event listeners to listen for the left and right arrows might be added (to advance the months and not just the days)
@simeg
Copy link
Collaborator

simeg commented Sep 6, 2017

Hi @nicolechung. Thanks for your suggestion. We currently do not have this on our roadmap and personally I don't see it as a high-prio. You seem to have a pretty good understanding of what it would require to implement so I'd be glad to review a PR from you adding this functionality.

@nreese nreese mentioned this issue Nov 29, 2017
Closed
@arqex
Copy link
Owner

arqex commented Sep 20, 2020

This is something that we should improve ASAP. Looks like a nice first contribution for anybody.

@arqex arqex mentioned this issue Sep 23, 2020
Open
6 tasks
@vahissan vahissan linked a pull request Dec 1, 2020 that will close this issue
Open
@vahissan
Copy link
Contributor

vahissan commented Dec 1, 2020

@arqex I've created a PR (#757). I hope it adds value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add keyboard accessibility vahissan/react-datetime
4 participants
@nicolechung @vahissan @arqex @simeg