Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Argo Events Kubernetes Admission Webhook Denial of Service #3077

Open
whynowy opened this issue Mar 22, 2024 · 1 comment
Open

Argo Events Kubernetes Admission Webhook Denial of Service #3077

whynowy opened this issue Mar 22, 2024 · 1 comment
Labels
bug Something isn't working stale

Comments

@whynowy
Copy link
Member

whynowy commented Mar 22, 2024

Describe the bug
send a large, crafted request and make the webhook crash due to OOMKill.

To replicate, please deploy Argo Events with the validating admission webhook. Then, port-forward to it:

kubectl port-forward svc/events-webhook 6443:443 -n argo-events

Then, run the PoC:

https://gist.github.com/jake-ciolek/9c86868cf71423a6b4cb6ff592181f51

via:

go run .

The webhook pod will crash after reading too much data. The workaround would be to implement its server with a LimitReader.

Thank you,
Jakub Ciolek

Additional context
Add any other context about the problem here.


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@whynowy whynowy added the bug Something isn't working label Mar 22, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had
any activity in the last 60 days. It will be closed if no further activity
occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

No branches or pull requests

1 participant