Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use QueueSubscribe for NATS events source? #2936

Closed
praveenperera opened this issue Dec 11, 2023 · 1 comment · Fixed by #3131
Closed

Use QueueSubscribe for NATS events source? #2936

praveenperera opened this issue Dec 11, 2023 · 1 comment · Fixed by #3131
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@praveenperera
Copy link

praveenperera commented Dec 11, 2023

Right now NATS event source uses subscribe and because of that the has to use the Active/Passive strategy for HA.

Could we not switch to using Queue Subscriptions giving us the ability to have Active/Active HA?


Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@praveenperera praveenperera added the enhancement New feature or request label Dec 11, 2023
@praveenperera praveenperera changed the title Use QueueSubscribe for nats events source? Use QueueSubscribe for NATS events source? Dec 11, 2023
@whynowy whynowy added the help wanted Extra attention is needed label Dec 20, 2023
@sysr9
Copy link
Contributor

sysr9 commented May 13, 2024

proposed as queue parameter

example-queued-subscription:
      url: nats://nats.argo-events.svc:4222
      jsonBody: true
      subject: "foo"
      queue: "my-queue"

if empty, or not specidied - will use default Subscribe logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants