Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ConnectorNotConnectedError: Connector not connected #45

Open
EvanYan1024 opened this issue Dec 11, 2023 · 11 comments
Open

ConnectorNotConnectedError: Connector not connected #45

EvanYan1024 opened this issue Dec 11, 2023 · 11 comments

Comments

@EvanYan1024
Copy link

When I didn’t install a Starknet wallet, I encountered an error when using connect.
image
image
It appears in this method mapModalWallets, it reads the name field, but get name throws an error

@bluecco
Copy link
Contributor

bluecco commented Dec 14, 2023

hi @EvanYan1024, what do you mean by When I didn’t install a Starknet wallet?

could you give some more details to understand the issue and how to reproduce?

@EvanYan1024
Copy link
Author

@bluecco, hello,This means that when my browser does not have the argentX and braavos extensions installed, for example, you can open the page in incognito mode, and this error will appear.

@bluecco
Copy link
Contributor

bluecco commented Dec 15, 2023

@EvanYan1024 I've tried to replicate with my local dapp, but I cannot achieve the same error (this is brave incognito, also tried with chrome and firefox incognito)

Screen.Recording.2023-12-15.at.10.02.47.mov

Also no exceptions throwed (checked the console log too)

Could you share:

  • the starknetkit version you're using
  • code (or the snippet) that implements starknetkit?

@EvanYan1024
Copy link
Author

@bluecco Thanks for your reply, you can try edge browser,
I guess this is the reason, you can check out my PR。
https://github.com/starknet-io/get-starknet/pull/207/files

@bluecco
Copy link
Contributor

bluecco commented Jan 23, 2024

@EvanYan1024 sorry for the delay, we're still waiting for the linked pr to be merged (and then update get-starknet react here)

@YanYuanFE
Copy link

@bluecco Thanks for your reply. It seems that the get-starknet library is no longer updated.

@lazarmitic
Copy link

We also have same issue in our dApp on Edge browser, is there a workaround, or we need to wait for get-starknet to merge above PR? Can we replace getDiscoveryWallets() from starknet-core with our own version and put it in starknet-kit?

@YanYuanFE
Copy link

@lazarmitic ,hi,you can use patch package to fix get-starknet,
https://www.npmjs.com/package/patch-package

@TEMHITHORPHE
Copy link

@bluecco Thanks for your reply, you can try edge browser, I guess this is the reason, you can check out my PR。 https://github.com/starknet-io/get-starknet/pull/207/files

This has been merged now, any updates ?

@bluecco
Copy link
Contributor

bluecco commented May 6, 2024

@TEMHITHORPHE pr is opened, should be merged tomorrow (after internal testing)
#97

@bluecco
Copy link
Contributor

bluecco commented May 6, 2024

will need this pr to be merged first

starknet-io/get-starknet#238

otherwise, current implementation will break ssr (ie: using nextjs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants