Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting values that change bit depth image take a long time to return #34

Open
GDYendell opened this issue Feb 25, 2020 · 0 comments
Open

Comments

@GDYendell
Copy link
Contributor

If, for example, photon_energy is changed, the detector returns bit_depth_image in the list of parameters that might have changed and should be fetched. This means the driver automatically fetches bit_depth_image image, which takes a few seconds to calculate on the detector. This has occasionally meant the readback for photon energy does not update for over 5 seconds, causing our GDA to fall over with a timeout.

Perhaps fetchParams could be run in a separate thread. Although, that could mean it is possible to start an acquisition based on a bit depth that is out of date, by setting photon_energy, which would then return straight away, reading the bit depth and opening a file with the matching (wrong) data type and then starting the acquisition. This could be avoided by setting some state when fetching that can be waited on by clients.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant