Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyinotify from PyPI is not Python 3.12 compatible #503

Open
z3ntu opened this issue Apr 30, 2024 · 2 comments
Open

pyinotify from PyPI is not Python 3.12 compatible #503

z3ntu opened this issue Apr 30, 2024 · 2 comments

Comments

@z3ntu
Copy link

z3ntu commented Apr 30, 2024

Hi, the version of pyinotify specified in requirements.txt (https://github.com/archlinux/archweb/blob/master/requirements_prod.txt#L2) is not Python 3.12 compatible, it tries to import asyncore but this doesn't exist anymore (ModuleNotFoundError: No module named 'asyncore').

In Arch Linux packaging this was patched https://gitlab.archlinux.org/archlinux/packaging/packages/python-pyinotify/-/commit/df875e727a19fb9e83d2af55cc5f368b94eec705 but if installed in a venv via PyPI this patch is not present of course.

Maybe it's time to do something about this dependency that wasn't updated in 9 years? https://github.com/seb-m/pyinotify/commits/master/

For now I'll patch it in the venv using the patch from the repo package, not sure what the best path forward is long-term.

@jelly
Copy link
Member

jelly commented May 6, 2024

Yes, we should switch as we also run it from a venv in production 😅

It is forked into seb-m/pyinotify#204

I'll look for some other alternatives.

@z3ntu
Copy link
Author

z3ntu commented May 15, 2024

Related commit: 4355b0f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants