Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make reproducible status visible for regular users #383

Open
orhun opened this issue Nov 11, 2021 · 2 comments
Open

Make reproducible status visible for regular users #383

orhun opened this issue Nov 11, 2021 · 2 comments

Comments

@orhun
Copy link
Member

orhun commented Nov 11, 2021

Screenshot (maintainer view):

Screenshot 2021-11-12 at 00-13-11 Arch Linux - xplr 0 16 3-1 (x86_64)

Screenshot (user view):

Screenshot 2021-11-12 at 00-14-17 Arch Linux - xplr 0 16 3-1 (x86_64)

Are there any security implications or side effects of making the rebuilderd result of packages visible for regular users? If not, I'd like to provide a PR to change this.

Reference:

{% if user.is_authenticated %}<tr>
<th>Reproducible Status:</th>
{% if rbstatus %}
<td id="rebuilderdstatus" class="rebuilderd-{{ rbstatus.status_str|lower }}">{{ rbstatus.status_str }}</td>
{% else %}
<td id="rebuilderdstatus">Unknown</td>
{% endif %}
</tr>
{% endif %}

@jelly
Copy link
Member

jelly commented Nov 12, 2021

No security issues, but as the status is experimental I decided to hide it for normal users as maintainers might have to explain it every time it goes bad.

We could think of adding an information label to the status which explains it's experimental.

@orhun
Copy link
Member Author

orhun commented Nov 19, 2021

No security issues, but as the status is experimental I decided to hide it for normal users as maintainers might have to explain it every time it goes bad.

Fair point.

We could think of adding an information label to the status which explains it's experimental.

Do you mean something like (experimental) Reproducible Status: Good ? What's in your mind?

Or maybe we can show the reproducibility status but use a different color (e.g. black or gray) for results to make it catch less attention?

e.g.

Screenshot 2021-11-19 at 23-29-44 Arch Linux - gcc 11 1 0-1 (x86_64)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants