Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Common API for Forge IItemDecorator and Fabric DynamicItemRenderer #495

Open
ShayBox opened this issue Apr 28, 2024 · 2 comments

Comments

@ShayBox
Copy link

ShayBox commented Apr 28, 2024

I believe these two APIs are very similar in what they do and could benefit from a common API (if possible).

@Fuzss
Copy link

Fuzss commented Apr 28, 2024

Don't you mean IClientItemExtensions::getCustomRenderer as an equivalent to Fabric's DynamicItemRenderer?

@ShayBox
Copy link
Author

ShayBox commented Apr 28, 2024

I'm not very familiar with either API right now, if getCustomRenderer is closer to DynamicItemRender then that should be used, there's also a deprecated Fabric BuiltinItemRenderer which might help support old Fabric versions that don't have DynamicItemRenderer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants