Heavy bug while looting on fishing

[Magnifikator]

This bug works only if your client settings are on autolooting (In German: Schnellplündern). I don't know the exactly expression in English. It's this setting when switched on it allows that all loot goes immediately into your bag.

Now go fishing as usual and wait for the first loot (fish).
Rightklick -> The loot goes immediately into your bag.
BUT now !
You are able to rightclick once more and get immediately the same loot into your bag again.
And this you can repeat several times as long as the fishing timer runs.

With this effect you can get easily 5-10x of the normal loot.
Players are happy, but it's not blizzlike :-)

[ghost]

There is also a bug that when you fish, your character may be still fishing even tho you cancelled it. So you will hold your fishing pole to fish but really your walking around and can't do no casting. If you want a picture for proof i will get one asap. I have the latest ArcEmu, and the WhyDB latest.

[Rezolute]

Maybe a check needed in:

void Player::HandleSpellLoot(uint32 itemid)
{
Loot loot;
std::vector< __LootItem >::iterator itr;

lootmgr.FillItemLoot(&loot, itemid);

for(itr = loot.items.begin(); itr != loot.items.end(); ++itr)
{
    uint32 looteditemid = itr->item.itemproto->ItemId;
    uint32 count = itr->iItemsCount;

    m_ItemInterface->AddItemById(looteditemid, count, 0);
}

}

To see how much loot is being actually there after you catch a fish then make it clear loot once the item is clicked on to be taken or auto looted. Sorry I'm new to WoW Emulation I moved over from EverQuest 2 Emulation so I will work on a patch to fix this.

Also: It might also be good to place a check so when you've caught a fish and the bobber is clicked on it automatically ends your fishing instead of keeping it going like stated in the above comments. (If this is like EQ you could probably even dupe hack while fishing without the two checks I'm stating.)