Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: rename traceeConfig to traceeConfigFile #3885

Closed
josedonizetti opened this issue Feb 21, 2024 · 1 comment · Fixed by #4018
Closed

helm: rename traceeConfig to traceeConfigFile #3885

josedonizetti opened this issue Feb 21, 2024 · 1 comment · Fixed by #4018
Assignees
@rscampos
Labels
area/kubernetes good first issue kind/feature

Comments

@josedonizetti
Copy link
Collaborator

There has been some confusion around traceeConfig option on the helm values, the idea behind it is to allow the user to inject a full config file, using helm --set-file, when configuring individual values, we can use https://github.com/aquasecurity/tracee/blob/main/deploy/helm/tracee/values.yaml#L61.

So, let's rename it to traceeConfigFile and add a comment explaining it on the values.yaml
@rscampos rscampos mentioned this issue May 2, 2024
Merged
@rscampos rscampos self-assigned this May 2, 2024
@rscampos
Copy link
Contributor

rscampos commented May 2, 2024

@josedonizetti what do you think: instead of using traceeConfigFile we simply use configFile? I thought this way because the config (that already exists) don't have tracee in the field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rscampos rscampos

Labels
area/kubernetes good first issue kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(helm): rename helm field config file rscampos/tracee
2 participants
@josedonizetti @rscampos