Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support SSL/TLS redis connection #155

Closed
chris-cmsoft opened this issue Jan 12, 2021 · 6 comments
Closed

Support SSL/TLS redis connection #155

chris-cmsoft opened this issue Jan 12, 2021 · 6 comments
Labels
🚀 enhancement New feature or request

Comments

@chris-cmsoft
Copy link

Current container only support redis:// protocol.

When connecting to redis using SSL/TLS, the rediss:// protocol is used.

Would it be worthwhile adding support for the rediss:// protocol from Trivy ?

@danielpacak
Copy link
Contributor

danielpacak commented Jan 14, 2021

What is your use case? Harbor itself does not currently support rediss:// connection URI.

Do you want to use different Redis instance or cluster for Harbor services (without TLS) and Trivy scanner adapter (with TLS)?

@danielpacak danielpacak added the additional-info-required Additional information required to close an issue label Jan 14, 2021
@chris-cmsoft
Copy link
Author

Some managed services are immediately provisioned with the rediss:// URI.

My use case is specifically DigitalOcean managed Redis.

Trivy is the first place I noticed it as it was the first component I deployed, but the same would be applicable to Harbor.

More a note for consideration than a requirement.
Ultimately your choice whether it's a worthwhile addition.

@danielpacak
Copy link
Contributor

Thank you for additional details @chris-cmsoft

Since this in an integral component of Harbor, if the community decides to add support for rediss:// to Harbor we'll do the same for this adapter.

@danielpacak danielpacak removed the additional-info-required Additional information required to close an issue label Jan 18, 2021
@danielpacak danielpacak added the 🚀 enhancement New feature or request label Mar 25, 2021
@danielpacak
Copy link
Contributor

Closing as a stale issue. What's more it makes sense only if the upstream Harbor does provide support for connecting to Redis with TLS

@yilmi
Copy link

yilmi commented Nov 2, 2021

Hi @danielpacak,

We have a helm chart at bitnami/charts that also uses this component and where we would like to support TLS connections to Redis as users often use external redis services.

I was looking at bitnami/charts#7691 when I realised that the components we use don't always support it.

Would you mind keeping this issue opened to help us track when this will become supported for the the harbor trivy scanner?

I believe this will become a more frequent use case, and eventually the community will add support for it. There is an issue currently opened for this - goharbor/harbor#13223

Thanks!

@danielpacak
Copy link
Contributor

Since Trivy is the default scanner in Harbor, we'll update this adapter service in scope of goharbor/harbor#13223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants