Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Can't view resources when there are a large number of resources #250

Open
stopWarByWar opened this issue Oct 30, 2022 · 4 comments
Open
Labels
bug Something isn't working

Comments

@stopWarByWar
Copy link

I can not get resources of address "0x05a97986a9d031c4567e15b797be516910cfcb4156312482efc6a19c0a30c948" with error
image

@0xFanz
Copy link

0xFanz commented Nov 1, 2022

you can change to another node RPC which is config more requests handling

@gregnazario
Copy link
Contributor

Yes, looks like this page is freezing at the moment, but no longer giving that error https://explorer.aptoslabs.com/account/0x05a97986a9d031c4567e15b797be516910cfcb4156312482efc6a19c0a30c948/resources

@gregnazario gregnazario added the bug Something isn't working label Jan 12, 2023
@gregnazario gregnazario changed the title [bug] can not get resources [bug] Can't view resources when there are a large number of resources Jan 12, 2023
@gregnazario
Copy link
Contributor

Note: This now hangs (retrieving all the resources), instead of erroring out.

@zacharydenton
Copy link
Contributor

zacharydenton commented Jan 12, 2023

The main bottlenecks in this page appear to be react-json-view and emotion (sx={{}}). It's possible to render all 9999 resources on https://explorer.aptoslabs.com/account/0x05a97986a9d031c4567e15b797be516910cfcb4156312482efc6a19c0a30c948/resources as (<pre>{JSON.stringify(resource)}</pre>) in about 300 ms on my machine (whereas the current implementation crashes the browser tab).

(ETA: While optimizing the page would be ideal, the pragmatic solution is of course to implement pagination.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants