Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package.swift copy Privacy Manifest Resource file #53

Open
FONickReichard opened this issue Feb 7, 2024 · 9 comments
Open

Package.swift copy Privacy Manifest Resource file #53

FONickReichard opened this issue Feb 7, 2024 · 9 comments

Comments

@FONickReichard
Copy link

FONickReichard commented Feb 7, 2024

Environment Details:
Version: 6.5.0
Dependency Management: SPM
Relates To: Privacy Manifest (#529) commit: 3daaa10

Hello,

Based on the following path structure: Sources/ApptentiveKit/Resources/PrivacyInfo.xcprivacy
I am wondering if the PrivacyInfo.xcprivacy file needs to be copied in the Package.swift file.

Ex:

   targets: [
        .target(
            name: "ApptentiveKit",
            dependencies: [],
            exclude: ["Info.plist"],
            resources: [.copy("Resources/SwiftPM.txt"), .copy("Resources/Distribution.plist"), .copy("Resources/PrivacyInfo.xcprivacy")]
        ),

Correct me if I'm wrong, I believe the PrivacyInfo.xcprivacy file should be included in the clients apps' bundle so that the privacy report can be generated after archiving a build.

Any feedback would be great.

Thank you

@RamyaSmg34
Copy link

Hello,

Even I am able to reproduce this issue, without .copy("Resources/PrivacyInfo.xcprivacy") under targets inside Package.swift file, we are not able to generate Privacy report after archiving a build.

Note: Tried by editing Package.swift file locally as below by including .copy("Resources/PrivacyInfo.xcprivacy") and was able to generate Privacy report.

 targets: [
        .target(
            name: "ApptentiveKit",
            dependencies: [],
            exclude: ["Info.plist"],
            resources: [.copy("Resources/SwiftPM.txt"), .copy("Resources/Distribution.plist"), .copy("Resources/PrivacyInfo.xcprivacy")]
        ),

Can you please look into this and help here

Thank you

@FONickReichard
Copy link
Author

@frankus Could we get an update on this when you're free. Thanks!

@frankus
Copy link
Collaborator

frankus commented Mar 1, 2024

@FONickReichard I'll get this prioritized. We seem to have a bit of a gap in our issue ingestion system where this has gotten lost in the shuffle.

@FONickReichard
Copy link
Author

Thank you for the update @frankus

@FONickReichard
Copy link
Author

Hey @frankus ,

Friendly check in. Is there an eta for a new version?

Thanks.

@frankus
Copy link
Collaborator

frankus commented Mar 25, 2024

Just released as part of the v6.6.0.

(We're aware of an issue with displaying surveys in this release (only) due to an API rollout taking longer than the SDK release. On the off chance you run into it should be fixed within 24 hours).

@MichaelWellsSM
Copy link

I believe the same would apply to the podspec... thank you.

@einsteinx2
Copy link

einsteinx2 commented May 7, 2024

Just released as part of the v6.6.0.

Still broken...

The current Package.swift file has .copy("PrivacyInfo.xcprivacy") instead of .copy("Resources/PrivacyInfo.xcprivacy") so it doesn't get included...

@einsteinx2
Copy link

I believe the same would apply to the podspec... thank you.

That's correct, it's also missing from the podspec, it must be specified as a resource. Specifically it's missing from this line:

spec.resource_bundles = { "ApptentiveKitResources" => [ "Sources/ApptentiveKit/Resources/*.lproj", "Sources/ApptentiveKit/Resources/Media.xcassets", "Sources/ApptentiveKit/Resources/Distribution.plist" ] }

which should be

spec.resource_bundles = { "ApptentiveKitResources" => [ "Sources/ApptentiveKit/Resources/*.lproj", "Sources/ApptentiveKit/Resources/Media.xcassets", "Sources/ApptentiveKit/Resources/Distribution.plist", "Sources/ApptentiveKit/Resources/PrivacyInfo.xcprivacy" ] }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants