Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Deprecated Monolithic Google Play Core Libs to new per-feature libraries #19

Open
eddiecrawford opened this issue Aug 17, 2023 · 4 comments

Comments

@eddiecrawford
Copy link

eddiecrawford commented Aug 17, 2023

Right now the SDK is using the old monolithic play core library 1.10.3, which was released in late 2021 / early 2022, and this is causing some conflicts in our dependency tree.

It would be awesome to migrate to the new feature specific play libraries as described here (ie: com.google.android.play:review).

Thanks!

@benbackstrom
Copy link

This is causing us some conflicts as well. We have other dependencies that require the newer feature-specific play libraries and cannot compile both sets. If we try then we get duplicate class errors in Gradle. If we try to exclude the duplicate classes then we can experience crashes in GooglePlayReviewManager, since it relies on old package names for Tasks:

com.google.android.play.core.tasks

...instead of the updated package name for the newer Tasks:

com.google.android.gms.tasks

So this may become a blocker for us against using Apptentive on Android. Please consider migrating soon. There are resources like this post and Google's own migration guide that make this migration fairly straightforward.

@anthonycr
Copy link

Adding some additional info that when targeting Android 14, there are breaking changes that force us to update to the 2.1.0 version of the feature-specific libraries mentioned above. Moving to those feature-specific libraries is blocked by apptentive using the monolithic libraries, which means that we can't target Android 14 until this library is updated to use the new artifacts.

@catsoft
Copy link

catsoft commented Nov 8, 2023

I did an update for Android 14
#22
You can wait till they make a release or you can build it locally. It helped to me

@anthonycr
Copy link

Looks like a new release was just put out that fixes this issue https://github.com/apptentive/apptentive-kit-android/releases/tag/v6.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants