Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toniq errors are not tracked #38

Closed
aaronjensen opened this issue Dec 6, 2016 · 6 comments
Closed

Toniq errors are not tracked #38

aaronjensen opened this issue Dec 6, 2016 · 6 comments

Comments

@aaronjensen
Copy link
Contributor

Toniq uses the error log to report errors. I thought that appsignal listened to that, but I'm not seeing errors when I intentionally cause them.

Should this work or is this not hooked up?

See: joakimk/toniq#29

@arjan
Copy link
Contributor

arjan commented Dec 6, 2016

The second reply from the ticket describes the exact issue: Appsignal also expects the process just to crash. It does not tie in to Elixir's logger but ties into the lower-level Erlang error_logger module.

I guess Appsignal could use a similar use_logger option as well (with the risk of having errors reported multiple times)

@aaronjensen
Copy link
Contributor Author

I see, thanks for the explanation. I'm checking to see if we can just add a hook to toniq rather than rely on a use_logger option, though that may not be a horrible thing. It'd just depend on how many duplicates we got in practice.

@arjan
Copy link
Contributor

arjan commented Dec 6, 2016

Okay, let me know how it goes. Appsignal has a send_error function which you can use in your hook to easily send an error.

@arjan
Copy link
Contributor

arjan commented Dec 6, 2016

Maybe, if you've found a solution, it would be nice to integrate this into the Appsignal extension directly; Appsignal could check whether Toniq is used and install its error handler.

@aaronjensen
Copy link
Contributor Author

👍 see joakimk/toniq#29 (comment) for the first draft.

@tombruijn tombruijn added this to the Elixir 1.2 milestone Feb 28, 2017
@jeffkreeftmeijer jeffkreeftmeijer modified the milestone: Elixir 1.2 Apr 6, 2017
@tombruijn
Copy link
Member

Closed in favor of #176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants