Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Siemens Sinumerik codes #28

Open
silopolis opened this issue May 19, 2021 · 6 comments
Open

Add support for Siemens Sinumerik codes #28

silopolis opened this issue May 19, 2021 · 6 comments
Assignees
Labels
feature New feature or request future Not able to implement soon stale-issue

Comments

@silopolis
Copy link

First thank you veeeery much for this excellent extension !

As I'm working on a Siemens Sinumerik (840d) driven machine, I'd love to see this NC's specific codes better supported for ".mpf" and ".spf" files, mainly for syntax highlighting.

For example blocks like:

  • WORKPIECE(,,,,,,,,): for stock definition
  • MSG(""): for operator messages
  • T="TOOL_BY_NAME": for tool names
  • TRANS/ATRANS, ROT/AROT...: for transformations
  • CYCLExxx(): for positionning and machining cycles
  • MCALL: for modal sub-program calling
  • ...

WIth a little guidance, I'd gladly help for this.

Thanks again. Keep the good stuff coming

@mikecentola mikecentola self-assigned this May 26, 2021
@mikecentola mikecentola added the feature New feature or request label May 26, 2021
@mikecentola
Copy link
Member

I'll add this to the feature list, but probably won't get to it in 0.7.X as I think it'll require a language server

@patcon
Copy link
Contributor

patcon commented Jun 22, 2021

Also, really grateful to find this project! 🎉 And eager to meet someone else on GitHub who's using a sinumerik 840D, @silopolis 👋

For reference, some other projects doing syntax highlighting for sinumerik flavour g-code:

EDIT: oh hey, just stumbled across what a language server was (hadn't heard of it) https://github.com/Microsoft/language-server-protocol

@mikecentola mikecentola added this to TODO in v0.8 via automation Dec 2, 2021
@darkross67
Copy link

@mikecentola, first of all thank you so much for creating this amazing extension !

It's been 5 years since I'm working as a CNC Engineer and programming for different CN controller, such as Heidenhain, NUM1060, FANUC and Siemens (840d), via CAD/CAM System like CATIA or PTC Creo.

I'm working a lot with NUM1060 language, and it really looks like GCode.

How can I do if I want to add this language, I don't know how to start and I have few questions in mind :

  • Do you prefer to stay for one specific CN Language ? and then maybe copy this project for another language, if so tell me more about the Licence, I really want to be clean about that.

  • If no, adding specific language features inside your code, but it kinds of bugs me because all the files/logo reference 'G-Code' and it will no longer be the case after that, it will be more 'CNC-Code' or something, if you know what I mean.

I will really appreciate your feedback after that and guide me how I can support.

PS: Sorry for the mistakes, I'm French...

@mikecentola
Copy link
Member

@mikecentola, first of all thank you so much for creating this amazing extension !

It's been 5 years since I'm working as a CNC Engineer and programming for different CN controller, such as Heidenhain, NUM1060, FANUC and Siemens (840d), via CAD/CAM System like CATIA or PTC Creo.

I'm working a lot with NUM1060 language, and it really looks like GCode.

How can I do if I want to add this language, I don't know how to start and I have few questions in mind :

  • Do you prefer to stay for one specific CN Language ? and then maybe copy this project for another language, if so tell me more about the Licence, I really want to be clean about that.

  • If no, adding specific language features inside your code, but it kinds of bugs me because all the files/logo reference 'G-Code' and it will no longer be the case after that, it will be more 'CNC-Code' or something, if you know what I mean.

I will really appreciate your feedback after that and guide me how I can support.

PS: Sorry for the mistakes, I'm French...

I know some machine tools may use other types of characters and function codes but I don't think we'd be disingenuous by keeping the name as "G-Code"

I think as soon as we can figure out the dynamic language server and get some more contributors to the gcode-reference project, it'll become very easy to add variations.

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@mikecentola mikecentola removed this from TODO in v0.8 Aug 2, 2022
@mikecentola mikecentola added the future Not able to implement soon label Aug 2, 2022
@github-actions
Copy link

github-actions bot commented Oct 2, 2022

This issue has been automatically marked as stale because it has not had recent activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request future Not able to implement soon stale-issue
Projects
None yet
Development

No branches or pull requests

4 participants