Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Endless Loop when Scene fails on_render_begin() #2919

Open
JaanWilli opened this issue Feb 7, 2022 · 0 comments
Open

Endless Loop when Scene fails on_render_begin() #2919

JaanWilli opened this issue Feb 7, 2022 · 0 comments

Comments

@JaanWilli
Copy link
Contributor

This issue occured while working on PR #2914, where the camera returns false in on_render_begin() when there are errors. In such a case, and endless loop is entered that infinitely calls on_render_begin(). All other cameras always return true and therefore never run into this problem, but the issue can easily be reproduced by forcing a return false.

It appears that the MasterRenderer skips the frame, if the scene entities failed to perform on_render_begin() (see here). It does so by returning renderer_controller.get_status(), which is ContinueRendering, but this is what causes the infinite loop. In my eyes, AbortRendering should be returned instead, like is done a bit further below.

Is there a reason that I am missing, why the rendering process should not be aborted here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant