Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test that limits max size of router json schema #5133

Closed
BrynCooke opened this issue May 10, 2024 · 0 comments · Fixed by #5137
Closed

Add test that limits max size of router json schema #5133

BrynCooke opened this issue May 10, 2024 · 0 comments · Fixed by #5137
Assignees
@BrynCooke

Comments

@BrynCooke
Copy link
Contributor

We have the potential that adding to the router config will cause the json schema to bloat over time.
Set a hard limit it to 500kb. So that we know to take action if this happens.
BrynCooke pushed a commit that referenced this issue May 10, 2024
enforce json schema < 500k
d909640 
Modify test to verify that the generated schema is less than 500k
Fixes #5133
@BrynCooke BrynCooke mentioned this issue May 10, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrynCooke BrynCooke

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

enforce json schema < 500k apollographql/router
1 participant
@BrynCooke