New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize "operation_name" value inside supergraph request #5008
base: dev
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
CI performance tests
|
75ad1e7
to
7a41e2b
Compare
7fe54cc
to
a56443c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it may be best if request.body.operation_name
actually reflects what's passed in, I don't think we need to actually recommend people use that, but it's critical that the user have the ability to access it if they needed it. Let's take an exercise to think through that request.body.variables
would be here, maybe? Do we want to change any of those things or keep them as opaque values? (Again the docs need to be clear about what you should use for a use case!)
But the thing that I think users are trying to accomplish is knowing what operation was executed. I'm not certain if that needs to be as rquest.body.operation_name
. It could just be something else (you tell me — query.executed_operation_name
or something?)
Currently, request.body.operation_name is a direct copy of operationName from the client request.
But this behavior is very confusing to customers who expect it to have an operation name, if any, extracted from the query.
Fixes #5014
Checklist
Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.
Exceptions
Note any exceptions here
Notes
Footnotes
It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this. ↩
Configuration is an important part of many changes. Where applicable please try to document configuration examples. ↩
Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions. ↩