Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[apollo-language-server] - unpin @apollo/federation #2675

Open
jas7457 opened this issue Dec 13, 2022 · 6 comments
Open

[apollo-language-server] - unpin @apollo/federation #2675

jas7457 opened this issue Dec 13, 2022 · 6 comments

Comments

@jas7457
Copy link

jas7457 commented Dec 13, 2022

@apollo/federation is explicitly pinned to version 0.27.0. Unfortunately, this version prohibits node versions > 17. This makes it so that our project is stuck using node 16, two major versions behind LTS. It seems that newer versions of @apollo/federation would allow for the newer versions of node.

I don't know enough about any breaking changes between @apollo/federation versions, so this may be unsafe since it is in the 0.x.x semver range, but I'd like to relax this hard-requirement a bit if possible.

@vladninja
Copy link

See: #2666

@sp90
Copy link

sp90 commented Jan 24, 2023

@vladninja im running version 19 and having the whole thing run smoothly

And #2666 is closed

@abisewski
Copy link

@jas7457 Have you found a workaround for this issue? Vercel will update soon, and all projects with a node version lower than 18 will fail to build.

@jas7457
Copy link
Author

jas7457 commented Jun 2, 2023

I have not found a workaround yet. Perhaps using resolutions can help, but that's a pretty ugly solution

@ts-candide
Copy link

As of v0.38, @apollo/federation now explicitly supports node 18. We can use the overrides field in package.json to specify that this version is used:

"overrides": {
  "@apollo/federation": "0.38.1"
}

Admittedly, I have only tried a subset of the client CLI actions, and so I'm unsure if v0.38 is fully compatible with this package. For our use case, though, this works and allows us to use apollo with node 18.

@shtefanilie
Copy link

shtefanilie commented Dec 27, 2023

For any one still facing this, the quickest way to fix it is to add the latest version to resolutions
And if you are inside a monorepo, just add it to the root package.json file

"resolutions": {
    "@apollo/federation": "0.38.1"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants