bugfix: fixed urls that missing the customized prefix such as '/apollo' #5138
Conversation
dosubot
bot
added
the
size:S
WalkthroughThe changes entail updating URL constructions in various JavaScript files within the Changes
Assessment against linked issues
Poem
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (6)
Files skipped from review as they are similar to previous changes (5)
Additional Context UsedLanguageTool (2)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
| @@ -11,6 +11,6 @@ Apollo 2.3.0 | |||
| * [apollo assembly optimization](https://github.com/apolloconfig/apollo/pull/5035) | |||
| * [update the config item table column width](https://github.com/apolloconfig/apollo/pull/5131) | |||
| * [sync apollo portal server config to apollo quick start server](https://github.com/apolloconfig/apollo/pull/5134) | |||
|
|
|||
| * [Fix missing **prefix path** of some URLs in Apollo Portal](https://github.com/apolloconfig/apollo/pull/5138) | |||
There was a problem hiding this comment.
Capitalize "URLs" for consistency.
- * [Fix missing **prefix path** of some URLs in Apollo Portal](https://github.com/apolloconfig/apollo/pull/5138)
+ * [Fix missing **prefix path** of some URLs in Apollo Portal](https://github.com/apolloconfig/apollo/pull/5138)Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| * [Fix missing **prefix path** of some URLs in Apollo Portal](https://github.com/apolloconfig/apollo/pull/5138) | |
| * [Fix missing **prefix path** of some URLs in Apollo Portal](https://github.com/apolloconfig/apollo/pull/5138) |
| * [sync apollo portal server config to apollo quick start server](https://github.com/apolloconfig/apollo/pull/5134) | ||
|
|
||
| * [Fix missing **prefix path** of some URLs in Apollo Portal](https://github.com/apolloconfig/apollo/pull/5138) | ||
| ------------------ |
There was a problem hiding this comment.
Add blank lines around the list of changes for proper Markdown formatting.
* [sync apollo portal server config to apollo quick start server](https://github.com/apolloconfig/apollo/pull/5134)
+
* [Fix missing **prefix path** of some URLs in Apollo Portal](https://github.com/apolloconfig/apollo/pull/5138)
+
------------------Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
| * [sync apollo portal server config to apollo quick start server](https://github.com/apolloconfig/apollo/pull/5134) | |
| * [Fix missing **prefix path** of some URLs in Apollo Portal](https://github.com/apolloconfig/apollo/pull/5138) | |
| ------------------ | |
| * [sync apollo portal server config to apollo quick start server](https://github.com/apolloconfig/apollo/pull/5134) | |
| * [Fix missing **prefix path** of some URLs in Apollo Portal](https://github.com/apolloconfig/apollo/pull/5138) | |
| ------------------ |
|
How about use template strings to concatenate strings, and the same type of address prefixes can be put in a common method? |
What's the purpose of this PR
Fix bug while importing the configuration's file
Which issue(s) this PR fixes:
Fixes #5137
Brief changelog
Add the prefix path such as /apollo to those urls that were missed in apollo-portal
Follow this checklist to help us incorporate your contribution quickly and easily:
mvn clean testto make sure this pull request doesn't break anything.CHANGESlog.Summary by CodeRabbit
New Features
Refactor
AppUtilprefix path method across multiple services to standardize URL generation and improve maintainability.