Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add github action google-java-format or not #4196

Open
Anilople opened this issue Jan 6, 2022 · 1 comment · May be fixed by #4200
Open

Add github action google-java-format or not #4196

Anilople opened this issue Jan 6, 2022 · 1 comment · May be fixed by #4200
Labels
chore Project chores such as CI settings, typos, etc. discussion Categorizes issue as related to discussion enhancement

Comments

@Anilople
Copy link
Contributor

Anilople commented Jan 6, 2022

Is your feature request related to a problem? Please describe.
Now the java code's format use google style, but sometime a contributor maybe forget format the code.

Describe the solution you'd like
There is a github action Google Java Format https://github.com/marketplace/actions/google-java-format

This action can help us format the java code before pr merged.

Do we need to use it?

Additional context
The historical java code maybe be formated too, need more investigation
@Anilople Anilople added enhancement discussion Categorizes issue as related to discussion chore Project chores such as CI settings, typos, etc. labels Jan 6, 2022
@nobodyiam
Copy link
Member

This sounds a good idea to me. We may submit a standalone pr to format the current codes first.

@Anilople Anilople linked a pull request Jan 8, 2022 that will close this issue
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore Project chores such as CI settings, typos, etc. discussion Categorizes issue as related to discussion enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use Google Java Format to format Java code automaticlly by github action Anilople/apollo
2 participants
@nobodyiam @Anilople