New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[improve][misc] KeyStores can now be utilised for performance testing #22692
Open
shasank112001
wants to merge
13
commits into
apache:master
Choose a base branch
from
shasank112001:enhancement/testclient
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[improve][misc] KeyStores can now be utilised for performance testing #22692
shasank112001
wants to merge
13
commits into
apache:master
from
shasank112001:enhancement/testclient
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
Your PR changes impact docs and you will update later.
label
May 10, 2024
shasank112001
force-pushed
the
enhancement/testclient
branch
from
May 10, 2024 13:03
50c9886
to
d0d5384
Compare
shasank112001
changed the title
[improve][testClient] KeyStores can now be utilised for performance testing
[improve][misc] KeyStores can now be utilised for performance testing
May 10, 2024
nodece
requested changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work.
BTW, this PR requires a PIP.
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/DefaultMessageFormatter.java
Outdated
Show resolved
Hide resolved
pulsar-testclient/src/main/java/org/apache/pulsar/testclient/PerformanceBaseArguments.java
Outdated
Show resolved
Hide resolved
pulsar-testclient/src/test/java/org/apache/pulsar/testclient/PerfClientUtilsTest.java
Outdated
Show resolved
Hide resolved
pulsar-testclient/src/test/java/org/apache/pulsar/testclient/PerformanceBaseArgumentsTest.java
Show resolved
Hide resolved
nodece
approved these changes
May 11, 2024
nodece
requested changes
May 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert return String.format(Locale.US, format, get_FloatValue(size));
.
shasank112001
force-pushed
the
enhancement/testclient
branch
from
May 11, 2024 07:20
47a92f6
to
09ef3f9
Compare
…erformanceBaseArguments.java Co-authored-by: Zixuan Liu <nodeces@gmail.com>
…erformanceBaseArgumentsTest.java Co-authored-by: Zixuan Liu <nodeces@gmail.com>
shasank112001
force-pushed
the
enhancement/testclient
branch
from
May 13, 2024 10:31
0a6839e
to
9ddc238
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22678
Main Issue: #22678
PIP: #22694
Motivation
If you want to create a TestClient which uses AuthenticationKeyStoreTls as its authPlugin, Pulsar Test Admin/Client utilized in Pulsar-perf is unable to setup a vaild SSL context due to the requirement of the property "useKeyStoreTls" to be "true" for using keystores properly.
Moreover, utilizing the property "useKeyStoreTls" requires the use of trust-stores and not trust certificates, therefore requiring additional trustStoreType, trustStorePath and trustStorePass as parameters to be available, to utilize PulsarPerf.
Modifications
The following changes have been made:
Verifying this change
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: PR