Add Filters to DO Images #1742
Closed
Add Filters to DO Images #1742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kami
reviewed
Sep 2, 2022
| """ | ||
| List all the available images. | ||
|
|
||
| :param ex_private: Filters only user (private) images. |
There was a problem hiding this comment.
Would be good to clarify that None (default value) means that no filtering is performed.
Also, is there a distinction between None and False? If there isn't, I think we should just default to False and remove Optional annotation.
Kami
reviewed
Sep 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
privateandtagfilter to DigitalOcean ImagesDescription
DigitalOcean accepts both
tag_nameandprivateparameters to filter images and Nodes.This PR adds these parameters using the
ex_*convention.https://docs.digitalocean.com/reference/api/api-reference/#tag/Images
Closes #1737
Status
Checklist (tick everything that applies)
Others
First contribution, will keep it as a Draft for now.