Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KYUUBI #6368] Flink engine supports user impersonation #6383

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

[KYUUBI #6368] Flink engine supports user impersonation #6383

wants to merge 7 commits into from
+282 −42

Conversation

wForget
Copy link
Member

@wForget wForget commented May 10, 2024

🔍 Description

Issue References 🔗

This pull request fixes #6368

Describe Your Solution 🔧

Support impersonation mode for flink sql engine.

Types of changes 🔖

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Test Plan 🧪

Behavior Without This Pull Request ⚰️

Behavior With This Pull Request 🎉

Related Unit Tests

Checklist 📝

Be nice. Be informative.

@wForget wForget self-assigned this May 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024 •
edited

Codecov Report

Attention: Patch coverage is 28.57143% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 58.30%. Comparing base (4cbecdc) to head (96f819d).
Report is 2 commits behind head on master.

Files Patch % Lines
...ache/kyuubi/engine/flink/FlinkProcessBuilder.scala 9.09% 17 Missing and 3 partials ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #6383      +/-   ##
============================================
- Coverage     58.36%   58.30%   -0.06%     
  Complexity       24       24              
============================================
  Files           656      656              
  Lines         40267    40290      +23     
  Branches       5498     5500       +2     
============================================
- Hits          23500    23493       -7     
- Misses        14268    14283      +15     
- Partials       2499     2514      +15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wForget wForget added this to the v1.10.0 milestone May 14, 2024
@wForget wForget marked this pull request as draft May 24, 2024 07:44
@pan3793 pan3793 changed the title [KYUUBI #6368] Support impersonation mode for flink sql engine [KYUUBI #6368] Flink engine supports user impersonation May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan3793 pan3793 pan3793 left review comments

Assignees

@wForget wForget

Labels
kind:build kind:documentation Documentation is a feature! module:common module:flink module:server
Projects
None yet
Milestone
v1.10.0
Development

Successfully merging this pull request may close these issues.

[FEATURE] Support impersonation mode for flink sql engine
3 participants
@wForget @codecov-commenter @pan3793