Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TASK][CHALLENGE] JDBC driver supports affected rows #6269

Open
3 tasks done
pan3793 opened this issue Apr 7, 2024 · 3 comments
Open
3 tasks done

[TASK][CHALLENGE] JDBC driver supports affected rows #6269

pan3793 opened this issue Apr 7, 2024 · 3 comments
Assignees

Comments

@pan3793
Copy link
Member

pan3793 commented Apr 7, 2024

What's the level of this task?

CHALLENGE

Code of Conduct

Search before creating

  • I have searched in the task list and found no similar tasks.

Mentor

  • I have sufficient expertise on this task, and I volunteer to be a mentor of this task to guide contributors through the task.

Skill requirements

  • Knowledge of Java, Thrift, JDBC

Background and Goals

JDBC standard requires the following method return affected rows.

java.sql.Statement#executeUpdate(java.lang.String) => int

Hive added such a feature in 4.0.0 https://issues.apache.org/jira/browse/HIVE-14388

Implementation steps

This is an umbrella ticket to track all sub-tasks

  • [TASK][EASY] Upgrade hive-service-rpc 4.0.0 #6252 covers thrift protocol upgrading, which adds an optional field numModifiedRows in TGetOperationStatusResp
  • Modify the JDBC driver to support affected rows, refer to HIVE-27815: Support update numModifiedRows hive#4819
  • As Kyuubi supports multi-computing engines, some engines like Spark themselves do not report affected rows but some engines like JDBC do. We can start with the JDBC engine to let them report affected rows after completing the DML operations, and propagate to client side
  • Making changes in computing engines to allow them to report affected rows (this is the most challenging part of this task)

Additional context

Introduction of 2024H1 Kyuubi Code Contribution Program

@pan3793 pan3793 changed the title [TASK][CHALLENGE] JDBC driver supports display affects rows [TASK][CHALLENGE] JDBC driver supports affected rows Apr 7, 2024
@slfan1989
Copy link
Contributor

@pan3793 Could you assign this issue to me? Thank you very much!

@pan3793
Copy link
Member Author

pan3793 commented Apr 10, 2024

@slfan1989 thanks, assigned.

@zhaohehuhu do you have minutes to address comments on #6262, so we can get it in and unblock this task

@pan3793
Copy link
Member Author

pan3793 commented Apr 19, 2024

@slfan1989 do you have any progress/questions on this task?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants