[KYUUBI #6236] Throw connectionClosed KyuubiSQLException when engine died #6237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
8 tasks
beryllw
changed the title
cxzl25
changed the title
wForget
reviewed
Apr 7, 2024
| e) | ||
| case te: TTransportException => | ||
| warn(s"Error $action $opType: Socket for ${session.handle} is closed", e) | ||
| KyuubiSQLException.connectionClosed(session.handle, e) |
There was a problem hiding this comment.
I don't have a strong option here, both seem fine to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃攳 Description
Issue References 馃敆
This pull request fixes #6236
Describe Your Solution 馃敡
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Types of changes 馃敄
Test Plan 馃И
Behavior Without This Pull Request 鈿帮笍
Behavior With This Pull Request 馃帀
Related Unit Tests
Checklist 馃摑
Be nice. Be informative.