Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]Run Kyuubi Server in local IDE, will create metrics dir which should be add to gitignore #4546

Closed
3 of 4 tasks
zwangsheng opened this issue Mar 17, 2023 · 5 comments · May be fixed by #6044
Closed
3 of 4 tasks
Labels
kind:bug This is a clearly a bug priority:major

Comments

@zwangsheng
Copy link
Contributor

Code of Conduct

Search before asking

  • I have searched in the issues and found no similar issues.

Describe the bug

When run kyuubi server in local IDE, kyuubi server will create metrics for store kyuubi server's metrics.

Run git status show

未跟踪的文件:
  (使用 "git add <文件>..." 以包含要提交的内容)
        metrics/

Found in .gitignore

metrics/report.json
metrics/.report.json.crc

Affects Version(s)

master

Kyuubi Server Log Output

No response

Kyuubi Engine Log Output

No response

Kyuubi Server Configurations

No response

Kyuubi Engine Configurations

No response

Additional context

No response

Are you willing to submit PR?

  • Yes. I would be willing to submit a PR with guidance from the Kyuubi community to fix.
  • No. I cannot submit a PR at this time.
@Z1Wu
Copy link

Z1Wu commented Jan 23, 2024

This modification will result in all folder whose name is metrics being ignored.

# for example, a normal metrics package  for spark-engine will be ignored due to this change
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/kyuubi/metrics/

if we want to ignore $repo_root/metrics created by local IDE, maybe we could change gitignore like this :

# gitignore after
/metrics/

# gitignore before 
metrics/

@pan3793
Copy link
Member

pan3793 commented Jan 23, 2024

the metrics created in working dir by default, what will happen if run test in IDEA?

@zwangsheng
Copy link
Contributor Author

Hi @Z1Wu , i try test in my local with following command:

  1. modify class under org.apache.kyuubi.metrics
  2. run git status

And output look fine to our expection.

截屏2024-01-23 12 01 29

@pan3793
Copy link
Member

pan3793 commented Jan 23, 2024

@zwangsheng all changes will be identified if you touch a git-tracked file, I suppose creating a new file under the metrics folder will be ignored, and git add -f <new_file> must be used then

@zwangsheng
Copy link
Contributor Author

Yes, i tried touch a file under metrics package, seems it has not been tracked. @Z1Wu Thanks for catching this. Would you like to raise a PR to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug This is a clearly a bug priority:major
Projects
None yet
3 participants