Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[druid 版本升级]请问下个版本大概多久发布，依赖的druid会升级到最新版本嘛? #6522

Open
God-Gan opened this issue May 6, 2024 · 7 comments · May be fixed by #6523
Open

[druid 版本升级]请问下个版本大概多久发布，依赖的druid会升级到最新版本嘛? #6522

God-Gan opened this issue May 6, 2024 · 7 comments · May be fixed by #6523

Comments

@God-Gan
Copy link

God-Gan commented May 6, 2024 •
edited

目前seata2.0.0使用的druid版本是1.2.7,但是这个版本的druid解析postgresql的 FETCH FIRST 1 rows only 语句会出现语法错误，druid社区已经在1.2.20+版本解决了这个问题：alibaba/druid@e400326
请问一下下一个seata版本大概多久升级，其中依赖的druid版本会升级到最新版本吗？
@funky-eyes
Copy link
Contributor

你可以提交一个pr来解决这个问题吗？
Can you submit a PR to solve this problem?

@God-Gan
Copy link
Author

God-Gan commented May 6, 2024

请问是直接修改dependencies目录下pom.xml中druid的版本到1.2.22，然后提交pr就可以了么？

@funky-eyes
Copy link
Contributor

请问是直接修改dependencies目录下pom.xml中druid的版本到1.2.22，然后提交pr就可以了么？

是的，然后我们来看下测试用例是否都正常通过，并且建议你升级后本地也进行一些测试
Yes, then let's see if the test cases pass normally, and it is recommended that you do some tests locally after the upgrade.

@funky-eyes funky-eyes linked a pull request May 6, 2024 that will close this issue
Open
1 task
@slievrly
Copy link
Member

slievrly commented May 8, 2024

@God-Gan Please fix the UT error.

@God-Gan
Copy link
Author

God-Gan commented May 8, 2024

好的，我会找时间尝试fix一下CI的问题 @slievrly

@God-Gan
Copy link
Author

God-Gan commented May 10, 2024 •
edited

@funky-eyes 请问seata-all依赖内置的druid包是专门用来解析sql的么？这个包的版本也是跟着pom.xml的druid版本同步升级吗。

@funky-eyes
Copy link
Contributor

@funky-eyes 请问seata-all依赖内置的druid包是专门用来解析sql的么？这个包的版本也是跟着pom.xml的druid版本同步升级吗。

yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

optimize: upgrade alibaba/druid version to 1.2.20 God-Gan/incubator-seata
3 participants
@slievrly @funky-eyes @God-Gan