Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Migrate the hg-style.xml to.editorconfig #2485

Open
2 tasks
returnToInnocence opened this issue Mar 18, 2024 · 1 comment
Open
2 tasks

[Feature] Migrate the hg-style.xml to.editorconfig #2485

returnToInnocence opened this issue Mar 18, 2024 · 1 comment
Labels
feature New feature good first issue Good for newcomers

Comments

@returnToInnocence
Copy link
Contributor

returnToInnocence commented Mar 18, 2024

Background

While working on #2457, we noticed that we were using both hugegraph-style.xml and .editorconfig to control the style of our code, so we wanted to try combining the functionality of these two files into a single file

Feature Description

  • Migrate the code format control configuration to .editorconfig

Some advantages

  • The .editorconfig file can define coding conventions that cannot be defined by hg-style.xml, such as insert_final_newline
  • The .editorconfig file does not require the user to make any additional configuration, such as importing code style. If this file exists in the project, it will be automatically invoked by default, and code sytle will be overwritten

    This is if the user allows the EditorConfig support of 🙈 IDEA to be enabled

What need to do

  • Migrate the hg-style.xml to .editorconfig
  • Add code format style for .md

Reference

How do I test the correctness of the results

  • TODO(It's a shame that I don't have a practical way to make sure it's correct😭)
@returnToInnocence returnToInnocence added the feature New feature label Mar 18, 2024
Copy link

dosubot bot commented Mar 18, 2024

To test the correctness of the results after migrating the code format control configuration from hugegraph-style.xml to .editorconfig in the incubator-hugegraph project, you can follow these steps:

  1. Code Formatting Tools Compatibility: Ensure that the tools or IDEs (Integrated Development Environments) used by the project's contributors support .editorconfig. Most modern IDEs like IntelliJ IDEA, Eclipse, and Visual Studio Code have built-in support or plugins available for .editorconfig.

  2. Automated Formatting Check: Implement a CI (Continuous Integration) pipeline step that checks if the code conforms to the .editorconfig settings. This can be achieved by using tools like checkstyle for Java, which can be configured to use .editorconfig directly or through plugins. For example, the eclipse-cs plugin allows Checkstyle to work with .editorconfig.

  3. Manual Review and Testing:

    • Review Changes: Manually review a significant sample of the code changes to ensure that the formatting changes are as expected.
    • Test Suite: Run the project's test suite to ensure that the code changes have not introduced any functional regressions.
  4. Community Feedback: Encourage the project contributors to pull the latest changes and report any issues or unexpected changes in code formatting. This feedback can be invaluable in identifying edge cases or configurations that may have been overlooked.

  5. Documentation: Update the project's documentation to inform contributors about the migration to .editorconfig and how they can configure their IDEs or editors to adhere to the new formatting rules.

By following these steps, you can systematically test and ensure the correctness of the results after migrating to .editorconfig for code formatting in the incubator-hugegraph project.

Regarding the structure of the hugegraph-style.xml file in the incubator-hugegraph project, it provides a comprehensive set of configurations for code styling, particularly focusing on Java, XML, and YAML languages, ensuring consistency and readability across the project's codebase. You can reference this structure when creating your .editorconfig file to ensure that all necessary formatting rules are covered.

For more details, you can refer to the .editorconfig file and the hugegraph-style.xml file in the incubator-hugegraph project.

I hope this helps! If you have any further questions, feel free to ask.

-Dosu

Sources

About Dosu

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@returnToInnocence returnToInnocence changed the title [Feature] migrate the hg-style.xml to.editorconfig [Feature] Migrate the hg-style.xml to.editorconfig Mar 18, 2024
@imbajin imbajin added the good first issue Good for newcomers label Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature good first issue Good for newcomers
Projects
Status: ⚾️ Newcomer Task
Development

No branches or pull requests

2 participants