Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KafkaTuningConfiguration spec is incorrectly documented & Implemented #16220

Open
acherla opened this issue Mar 30, 2024 · 0 comments
Open

KafkaTuningConfiguration spec is incorrectly documented & Implemented #16220

acherla opened this issue Mar 30, 2024 · 0 comments

Comments

@acherla
Copy link

acherla commented Mar 30, 2024

Affected Version

28.x and 29.x versions

Description

There seems to be a minor bug in the KafkaSupervisorTuningConfig implementation which is no longer showing the chatAsync or the numPersistThreads configuration when saving kafka supervisor jobs in the druid console https://github.com/apache/druid/blob/druid-29.0.1-rc1/extensions-core/kafka-indexi[…]ruid/indexing/kafka/supervisor/KafkaSupervisorTuningConfig.java

per the docs https://druid.apache.org/docs/latest/ingestion/kafka-ingestion/#tuning-configuration these tuning configuration parameters should be available.

I figured numPersistThreads would likely come in the 30.x release for druid, as the MR for it was merged a week after the 29.0 release, and didnt make the cut off period for it back in jan.

for chatAsync seems like it was removed back in 28.x but the documentation is just reflecting an incorrect configuration option. #14692

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant