Configurable Authorization #885
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #835
Rationale for this change
In the current state, the flight sql do handshake method uses a hardcoded username and password for authorization. One of the essential features for production readiness is to improve the security posture by having configurable authorization. The goal of this PR is to add a simple abstraction (the "Authorizer" trait) that allows for implementations of a variety of commonly used authorization schemes (basic auth, jwt, ldap, etc.). I only implemented basic auth for now in a backwards-compatible way so I can get feedback on the approach.
What changes are included in this PR?
This PR adds a new trait "Authorizer" that has a simple validate method that is passed the value of the authorization metadata the client sends with the request. Implementations can be created for basic authentication, jwt, ldap, etc. I've made the validate function async so if implementations require http requests over the network, this is supported.
Are there any user-facing changes?
The PR is meant to be backwards compatible, defaulting to basic auth with same username/password.