Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDVPlugin's viewController should just be a CDVViewController #1428

Open
dpogue opened this issue Apr 26, 2024 · 0 comments
Open

CDVPlugin's viewController should just be a CDVViewController #1428

dpogue opened this issue Apr 26, 2024 · 0 comments
Milestone

Comments

@dpogue
Copy link
Member

dpogue commented Apr 26, 2024

Feature Request

Motivation Behind Feature

CDVPlugin has a viewController property that is currently typed as UIViewController*. However, it is only ever set from within CDVViewController and is always set to a CDVViewController* instance.

Feature Description

We should just update the CDVPlugin API so that viewController is typed as CDVViewController* rather than UIViewController*.

Since CDVViewController is a subclass of UIViewController this shouldn't break any plugins, but it is an API change and should be handled in the next major.

Alternatives or Workarounds

Currently the standard practice is to just cast (CDVViewController*)self.viewController everywhere, which works fine but is kinda annoying.

@dpogue dpogue added this to the 8.0.0 milestone Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant