Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the Maven release #5887

Open
jamesnetherton opened this issue Mar 18, 2024 · 1 comment
Open

Optimize the Maven release #5887

jamesnetherton opened this issue Mar 18, 2024 · 1 comment
Assignees

Comments

@jamesnetherton
Copy link
Contributor

Description

We deploy a lot of redundant stuff.

  • integration-test-groups/*
  • integration-tests-jvm/*
  • perf-regression

The only test JARs that need to be deployed are in the integration-tests module.

@jamesnetherton
Copy link
Contributor Author

This appears to be trickier than it first seems. I was hoping to just add a property for <maven.deploy.skip>true</maven.deploy.skip> to the parent of the modules mentioned above.

But due to the parent that the sub-modules use, it has no effect. You have to explicitly add the property in each sub-module pom.xml. Which is a pain to maintain.

So I thought of adding something extra to the cq-maven-plugin format mojo that could configure the property automatically like:

<mavenDeploySkip>
    <basedir>${project.basedir}</basedir>
    <includes>
        <include>integration-test-groups/**/pom.xml</include>
        <include>integration-tests-jvm/**/pom.xml</include>
        <include>tooling/perf-regression/pom.xml</include>
    </includes>
</mavenDeploySkip>

It works. Just not sure if that's the right way to go. WDYT @ppalaga?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant