Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example containers using old images #417

Open
allentc opened this issue Feb 3, 2023 · 7 comments
Open

Example containers using old images #417

allentc opened this issue Feb 3, 2023 · 7 comments
Labels
good first issue Good for newcomers

Comments

@allentc
Copy link

allentc commented Feb 3, 2023

Some of the images that appear in example/docker-compose.yml are very old. Example:

  • prometheus v2.25.0 (2021-02-17)
  • grafana 7.3.7 (2021-01-14)
  • etcd 3.4.15 (2021-02-26)

I'd offer a pull request to update images but I haven't found any compatibility matrix or other information on what has been qualified for use with APISIX.

@Neilblaze
Copy link

@navendu-pottekkat can you have a look at this please? I'm also curious whether we have a set of updated images for the same which will be potentially used as a replacement?

@pottekkat
Copy link

@Neilblaze Thank you for the ping. @allentc Thank you for opening this issue.

@Neilblaze yes, these could be updated. I think we can use the latest LTS versions of each of the images. Prior to making a pull request, please test and check if everything is working as intended.

We can use the existing images but bump the version. I don't there would be anything else to change but look out for compatibility issues.

@juzhiyuan
Copy link
Member

Prometheus & Grafana are for the all-in-one case, +1 to upgrade them, but do we really need a all-in-one sample docker compose?

@soulbird
Copy link
Contributor

I don't think all-in-one has any effect, we can consider deleting it

@Neilblaze
Copy link

Neilblaze commented Feb 27, 2023

I'm a bit confused about whether to remove Prometheus and other images entirely from the compose file. Would you mind sharing some light on this? And else, if I want to upgrade them in general, where can I get the latest images that would be used as potential replacement?

cc: @juzhiyuan , @soulbird

@juzhiyuan
Copy link
Member

, if I want to upgrade them in general, where can I get the latest images that would be used as potential replacement?

To confirm: "them" - do you mean Prometheus, APISIX, and other components?

For this issue, welcome to file a PR to upgrade them.

@juzhiyuan juzhiyuan added the good first issue Good for newcomers label Feb 28, 2023
@pottekkat
Copy link

@Neilblaze You can use the later versions of the same images from Docker Hub.

lucabotti added a commit to lucabotti/apisix-docker that referenced this issue Jan 24, 2024
lucabotti added a commit to lucabotti/apisix-docker that referenced this issue Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

5 participants