Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation offered #27

Open
prunacomar opened this issue Aug 13, 2023 · 5 comments
Open

Translation offered #27

prunacomar opened this issue Aug 13, 2023 · 5 comments

Comments

@prunacomar
Copy link
Contributor

Hi there. Great project! I have a CSV file with all the name you use for the elements translated into Spanish. If you think it might be helpful to add a translated version (or eventually add another property like "NAME_ES" or "NAME_SP" for example, just let me know and I send it over.

@prunacomar
Copy link
Contributor Author

Hi there! As an addition to my previous comment: I see lots of minor adjustments to the data that can be done. As a couple of examples, for "Pamaps cultures", the correct name should be "Pampas cultures", and the geojson points seems to be ordered different at some years (so, for example, files world_900.geojson and world_1000.geojson start different, while there's no noticeable different in the region). If you agree, I can help to tidy all these and share with you, it you are willing to receive and merge this adjustments after revision. Please let me know.

@aourednik
Copy link
Owner

Hi, yes, many thanks for your proposal. I am willing to receive the pull requests

@prunacomar
Copy link
Contributor Author

Awesome! 2 initial pull requests sent. #36 & #37

@prunacomar
Copy link
Contributor Author

Before translating, I think it's important to organize the data. Same cultures receive different names in different files. As a simple example: Teotihuacán appears also as Teotihuacàn or Teotihuac�n.

Besides correcting the names, I think it'd very useful to add an "id" (perhaps simply an integer number) to each element, and repeat when the same element continues in another years. Then, you can say "all this Teotihuacán are the same folks". Or, if you want to add some extra complexity, some other relations, like "continues", so you can say for example "British American Colonies" "is continued by" "United States of America".

@prunacomar
Copy link
Contributor Author

Hey there! Were you able to review this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants