Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pagination #8

Open
ahmedbesbes opened this issue Dec 27, 2019 · 8 comments
Open

Adding pagination #8

ahmedbesbes opened this issue Dec 27, 2019 · 8 comments

Comments

@ahmedbesbes
Copy link

ahmedbesbes commented Dec 27, 2019

Hello @anuraghazra

I really like your blog and i'm currently using it as a way to learn gatsby and as a template for my portfolio.

I had a question regarding the blog posts though, is it possible to add a pagination? to display for example 5 posts per page. this would be superb!

Ahmed

@anuraghazra
Copy link
Owner

Hi @ahmedbesbes, glad you liked it. ❤️

Well, actually I did not made my site to work as a gatsby template but anyways, currently it does not support pagination but it can be fairly easily added.
I was going to add the pagination feature soon but got busy doing some other work.

Here are some resources you can take a look at if you want to add it yourself:
https://www.gatsbyjs.org/docs/adding-pagination/
https://www.gatsbyjs.org/packages/gatsby-paginate/
https://nickymeuleman.netlify.com/blog/gatsby-pagination

Let me know if you have any further queries, 😄

also, I saw that you you created this repo which is ok, as long as you reference the original repository / give credit to the original site in the footer. (Or just work on the forked repo)

@ahmedbesbes
Copy link
Author

Sure! your awesome work is credited for sure!
I'll have a look at the links you sent.

@anuraghazra
Copy link
Owner

Cool 😄
Let me know if you have some issues / queries about my ugly codebase. I'm always happy to help.

I'm not going to close this until I add the pagination feature.

I will work on this after holidays.
Hope you are also having a great time too. 😃

@ahmedbesbes
Copy link
Author

Great ! i'd love to see you contribution on this feature.
Meanwhile, i'll try to wrap my head around it ! :)

@ahmedbesbes
Copy link
Author

ahmedbesbes commented Dec 27, 2019

Oh and btw: here's my website: https://gallant-stonebraker-e1598f.netlify.com/

Feel free if you have any comment, suggestion... It's still under construction.

ps: I'll add your name in the footer in the next deploy. ;)

@anuraghazra
Copy link
Owner

Looks good!

Well you should change this
https://github.com/ahmedbesbes/gatsby-blog/blob/master/config/website.js#L19

@anuraghazra
Copy link
Owner

anuraghazra commented Jan 5, 2020

Hey @ahmedbesbes please change the above configurations.. And your google Analytics id, you are hurting my site's SEO.. And my google search results are indexing your site too. Please change those configs ASAP.

Screenshot_2020-01-05-12-07-47-972_com android chrome

Edit: huh... Google is getting mad.. You changed the configs. But why does it show up 🤔 that's weird. Something is wrong.

@ahmedbesbes
Copy link
Author

Hello @anuraghazra

I changed everything in the code including disqus name, google analytics id, and everything related to your previous configuration. Besides, I checked again, your name doesn't appear on any page I'm using

you can check the code on my repo: https://github.com/ahmedbesbes/gatsby-blog/

Sorry if something hurted your SEO, it was not my intention. don't hesitate to report if something is wrong or missing in the code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants