[Windows] Update antrea-agent image using Server 2022 #6265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump up the basic image for Antrea Agent on Windows to Server 2022 The change includes, * Use servercore:ltsc2022 in "antrea/base-windows". This is because running "sh" command is not supported in nanoserver:ltsc2022, it returns error code "-1073741511", but in Server2019, it returns 0. This caused we can't use nanoserver:ltsc2022 as a base to compile the antrea-agent binary any more. * Use Windows "curl" command to download the utilities in base-windows, and drop the previous powershell command "Invoke-WebRequest -UseBasicParsing". This is because the Windows curl command is more efficiency. * The final antrea Windows image "antrea/antrea-windows" is built based on mcr.microsoft.com/powershell:lts-nanoserver-ltsc2022. Signed-off-by: Wenying Dong <wenyingd@vmware.com>
wenyingd
force-pushed
the
windows_img_server2022
branch
from
e62710f
to
4e30db4
Compare
wenyingd
changed the title
XinShuYang
reviewed
May 6, 2024
| @@ -1 +1 @@ | |||
| 1809 | |||
| ltsc2022 | |||
There was a problem hiding this comment.
After adding support for Windows Server 2022 in Antrea, should we also announce that we will no longer maintain Antrea on Windows Server 2019 at the same time?
luolanzone
added
the
area/OS/windows
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bump up the basic image for Antrea Agent on Windows to Server 2022
The change includes,
Fix: #6290