Unexpected error log message in antrea-mc-controller for leader

[antoninbas]

I observed the following error log:

E0326 21:26:11.127301       1 stale_controller.go:71] "Fail to get MemberClusterAnnounces" err="the cache is not started, can not read objects"

With a bit more context:

I0326 21:26:11.126810       1 leader.go:122] "Leader MC Controller Starting Manager"
I0326 21:26:11.127037       1 stale_controller.go:97] "Starting StaleResCleanupController"
I0326 21:26:11.127301       1 server.go:50] "starting server" kind="health probe" addr="[::]:8080"
E0326 21:26:11.127301       1 stale_controller.go:71] "Fail to get MemberClusterAnnounces" err="the cache is not started, can not read objects"
I0326 21:26:11.127633       1 server.go:191] "Starting webhook server" logger="controller-runtime.webhook"
I0326 21:26:11.128119       1 certwatcher.go:161] "Updated current TLS certificate" logger="controller-runtime.certwatcher"
I0326 21:26:11.128596       1 server.go:242] "Serving webhook server" logger="controller-runtime.webhook" host="" port=9443
I0326 21:26:11.129095       1 certwatcher.go:115] "Starting certificate watcher" logger="controller-runtime.certwatcher"
I0326 21:26:11.232539       1 controller.go:178] "Starting EventSource" controller="memberclusterannounce" controllerGroup="multicluster.crd.antrea.io" controllerKind="MemberClusterAnnounce" source="kind source: *v1alpha1.MemberClusterAnnounce"

It is probably harmless, but we could also probably avoid it with a more "correct" initialization order?

cc @luolanzone

[roopeshsn]

Hi @antoninbas! What's the correct initialization order? That information will help me to work on this issue.

[antoninbas]

Hi @antoninbas! What's the correct initialization order? That information will help me to work on this issue.

A correct initialization order would be one that doesn't produce this error.

Maybe the manager should be started before running the staleController:

antrea/multicluster/cmd/multicluster-controller/leader.go

Lines 126 to 131 in dcf9b4c

	go staleController.Run(stopCh)
	klog.InfoS("Leader MC Controller Starting Manager")
	if err := mgr.Start(ctrl.SetupSignalHandler()); err != nil {
	return fmt.Errorf("error running Manager: %v", err)
	}

This can probably be confirmed with a little bit of research (controller-runtime library documentation & examples).