New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes clippy warnings #275
Conversation
For the first warning, I guess it would be safer to For the functions with too many parameters, I'd just ignore them, as these are initializing structs with many fields anyway, so adding For the last error (src/gen/generator.rs:65:70), just make the return type be a Also, it would be nice to run Thanks for looking into this! |
Done, but destructuring
Ok, done.
I just created a type to limit API breaking. Why the
Done. |
Yep, the visibility can be |
where WIDGET: Widget + WidgetTest + 'static, | ||
WIDGET::Msg: DisplayVariant + 'static, | ||
{ | ||
gtk::init().map_err(|_| ())?; | ||
gtk::init()?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I missed a few things in the first review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I guess we could run clippy
on the examples, but that probably requires fixing the code generation, so let's stop here for this PR.
Ready to merge?
Yes, it’s ok for me. |
Actually pub items is not really public (proc-macro lib forbids pub items other than proc macro). So I created a struct type for this return type. |
Fixes #239 & #254
This PR is incomplete, there is still 4 warnings:
I don’t know how fix that.